-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Catch and log pandas import errors #58744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vincbeck
merged 1 commit into
apache:main
from
aws-mwaa:onikolas/catch_pandas_import_error
Dec 1, 2025
Merged
Catch and log pandas import errors #58744
vincbeck
merged 1 commit into
apache:main
from
aws-mwaa:onikolas/catch_pandas_import_error
Dec 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandas is used if the user optionally selects advanced output processing when providing `show_results=True` (default is False) to GlueDataQualityRuleSetEvaluationRunOperator and GlueDataQualityRuleSetEvaluationRunSensor However, the original PR (apache#39923) adding these operators and sensors did not include Pandas as a dependency of the Amazon Provider Package. I assume this is because Pandas is quite a heavy dependency that we don't want all users to have to install just for this very small usecase. So this commit catches the exception and logs to the user rather than failing catastrophically as it does now.
Contributor
Author
|
@gopidesupavan As the original author, can you confirm why we didn't add Pandas as a dependency (that I can see anyway)? |
Lee-W
reviewed
Nov 27, 2025
potiuk
approved these changes
Nov 29, 2025
Lee-W
approved these changes
Nov 29, 2025
vincbeck
approved these changes
Dec 1, 2025
70 tasks
o-nikolas
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Dec 2, 2025
o-nikolas
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Dec 3, 2025
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Dec 3, 2025
Pandas is used if the user optionally selects advanced output processing when providing `show_results=True` (default is False) to GlueDataQualityRuleSetEvaluationRunOperator and GlueDataQualityRuleSetEvaluationRunSensor However, the original PR (apache#39923) adding these operators and sensors did not include Pandas as a dependency of the Amazon Provider Package. I assume this is because Pandas is quite a heavy dependency that we don't want all users to have to install just for this very small usecase. So this commit catches the exception and logs to the user rather than failing catastrophically as it does now.
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
Pandas is used if the user optionally selects advanced output processing when providing `show_results=True` (default is False) to GlueDataQualityRuleSetEvaluationRunOperator and GlueDataQualityRuleSetEvaluationRunSensor However, the original PR (apache#39923) adding these operators and sensors did not include Pandas as a dependency of the Amazon Provider Package. I assume this is because Pandas is quite a heavy dependency that we don't want all users to have to install just for this very small usecase. So this commit catches the exception and logs to the user rather than failing catastrophically as it does now.
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
Pandas is used if the user optionally selects advanced output processing when providing `show_results=True` (default is False) to GlueDataQualityRuleSetEvaluationRunOperator and GlueDataQualityRuleSetEvaluationRunSensor However, the original PR (apache#39923) adding these operators and sensors did not include Pandas as a dependency of the Amazon Provider Package. I assume this is because Pandas is quite a heavy dependency that we don't want all users to have to install just for this very small usecase. So this commit catches the exception and logs to the user rather than failing catastrophically as it does now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas is used if the user optionally selects advanced output processing when providing
show_results=True(default is False) to GlueDataQualityRuleSetEvaluationRunOperator and GlueDataQualityRuleSetEvaluationRunSensorHowever, the original PR (#39923) adding these operators and sensors did not include Pandas as a dependency of the Amazon Provider Package. I assume this is because Pandas is quite a heavy dependency that we don't want all users to have to install just for this very small usecase. So this commit catches the exception and logs to the user rather than failing catastrophically as it does now.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.